[PATCH] Leak in sftp_get_connection ()



Hi,

Bug #355468 has a patch to fix a leak in sftp_get_connection (). I
attach it here as well for you to review.

Also, please check bug #355470, as it includes a small documentation
fix.

Thanks,

Claudio

-- 
Claudio Saavedra <csaavedra alumnos utalca cl>
? compile
? config.status.lineno
? configure.lineno
? gnome-vfs-zip
? patch-leak.diff
Index: modules/sftp-method.c
===================================================================
RCS file: /cvs/gnome/gnome-vfs/modules/sftp-method.c,v
retrieving revision 1.51
diff -u -p -r1.51 sftp-method.c
--- modules/sftp-method.c	29 Dec 2006 01:06:21 -0000	1.51
+++ modules/sftp-method.c	29 Dec 2006 01:53:31 -0000
@@ -1589,6 +1589,8 @@ sftp_get_connection (SftpConnection **co
 			g_mutex_lock ((*connection)->mutex);
 			(*connection)->hash_name = hash_name;
 			g_hash_table_insert (sftp_connection_table, hash_name, *connection);
+		} else {
+			g_free (hash_name);
 		}
 	}
 #if 0


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]