Re: create_drive_from_mount_point: possible typo



On Sat, 2005-03-19 at 19:23 +0300, Oleg Sharoiko wrote:
> Hello!
> 
> The beginning of create_drive_from_mount_point (lines 631-635 of 
> libgnomevfs/gnome-vfs-volume-monitor-daemon.c) currently is
> 
>  	if (mount->is_loopback ||
>  	    !(mount->is_user_mountable ||
>  	      g_str_has_prefix (mount->device_path, "/vol/"))) {
>  		return NULL;
>  	}
> 
> But shouldn't mount->device_path be changed to mount->mount_path ?
> It's ok for me to have mounts in /vol, but I'd never expect devices to be 
> there. Of course I could miss something.
> 
> p.s. I'm not on the list, please keep my e-mail in To: or Cc: if you want to 
> reply.

It does look quite strange. /vol is a solaris thing, right. Any sun
person here who can comment on this?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a lonely soccer-playing jungle king on the edge. She's a virginal 
foul-mouthed journalist with the power to see death. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]