Build failure in cdda-cddb.c


I am doing a jhbuild and I encountered a build error:

cc1: warnings being treated as errors
cdda-cddb.c: In function 'CDDBRead':
cdda-cddb.c:637: warning: 'disc.disc_totaltracks' is used uninitialized
in this function

I looked and it appears to be correct. I found commented call to CDStat
and uncommented and updated it (the CDStat parameters had changed it
seemed). And now gnome-vfs builds.

The patch is attached.

I am using gcc-4.0 on ubuntu breezy (current development version) with
anoncvs of this morning.

I did not test the patch in actual gnome desktop environment because I
don't have a way to yet, since jhbuild is still only 1/3 done. But I
ran a few of the test programs in tests directory and encountered no

Hope this is usful. I am not on the list so CC me in responses.

Index: modules/cdda-cddb.c
RCS file: /cvs/gnome/gnome-vfs/modules/cdda-cddb.c,v
retrieving revision 1.12
diff -u -r1.12 cdda-cddb.c
--- modules/cdda-cddb.c	13 Apr 2005 23:00:32 -0000	1.12
+++ modules/cdda-cddb.c	21 Jun 2005 14:41:01 -0000
@@ -599,7 +599,7 @@
   if(socket==-1) return FALSE;
-  /* CDStat(cd_desc,&disc,TRUE); */
+  CDStat(cd_desc->ioctl_fd,&disc,TRUE);

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]