Re: [patch] improved hal support for gnome-vfs
- From: Chipzz <chipzz ULYSSIS Org>
- To: TazForEver dlfp org
- Cc: gnome-vfs-list gnome org
- Subject: Re: [patch] improved hal support for gnome-vfs
- Date: Fri, 1 Jul 2005 21:17:15 +0200 (CEST)
On Fri, 1 Jul 2005, Benoît Dejean wrote:
> > * Does this work with any version of libhal, or should we update the
> > libhal version requirement?
> >
> > +static char *
> > +_hal_size_as_string (gint64 size)
> > +{
> > ....
> > + char* sizes_str[] = {"K", "M", "G", "T", NULL};
> > + gint64 cur = 1000L;
> > + gint64 base = 10L;
> > + gint64 step = 10L*10L*10L;
> > + int cur_str = 0;
> >
> > Gnome in general, and gnome-vfs in particular uses 1024 for disk sizes.
> > Actually, this code should probably just use the function:
> > gchar* gnome_vfs_format_file_size_for_display (GnomeVFSFileSize size)
>
> HAL is plain right and uses SI prefixes. gnomevfs is wrong. See
> http://bugzilla.gnome.org/show_bug.cgi?id=301838.
Historically IT has deviated from the 1000 rule and that's just the way
it is. Claiming 1kB is 1000bytes makes you sound like a marketing droid,
and I think it's false advertising.
Totally opposed. There's enough of this bullshit yet.
Chipzz AKA
Jan Van Buggenhout
--
------------------------------------------------------------------------
UNIX isn't dead - It just smells funny
Chipzz ULYSSIS Org
------------------------------------------------------------------------
"Baldric, you wouldn't recognize a subtle plan if it painted itself pur-
ple and danced naked on a harpsicord singing 'subtle plans are here a-
gain'."
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]