Re: [PATCH] SMB user/password caching across shares

[Alexander Larsson <alexl redhat com>]

On Mon, 2005-01-24 at 20:06 +0000, Nielsen wrote:
> Alexander Larsson wrote:
> > Should we really check this and return before checking the actual
> > server_cache. If we're currently connected to the server/share using a
> > specific password that is not the default one, we should use that.
> > 
> > Lets see if i can make up an example where this breaks:
> > 
> > Say you connect to a server anonymously, then you later access a
> > specific share on that server by name (because it doesn't allow
> > anon). Later we need another connection to the original anon share,
> > but now we're gonna use the user/password instead of anon for the new
> > connection. As long as there is an outstanding connectiong to a
> > specific server/share we should always use the same user/password for
> > that, otherwise things like access rights etc are random depending on
> > which connection you happen to get.
> 
> Good point, fixed:
> 
> http://bugzilla.gnome.org/attachment.cgi?id=36479
> 
> Also:
> - Fixed memory leak in lookup_user_cache
> - Use cache even when user name specified in uri (when possible)

I commited this to get it into todays release (we're even more frozen
after that). However, i still think the same issue i listed above
exists:

1. access smb://server/share1
   enter username user1, password1
2. access smb://server/share2
   last user/password fails, we ask for a new, log in and save
   this as the default user/password for this share
3. the same process that did 1 does more i/o to it, needing to
   start a new connection. Since it doesn't specify a user the lookup
   in initial_authentication fails, and we fall back to using the
   default user, which is not the same as for the other active
   connection to server/share1.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an impetuous sweet-toothed filmmaker haunted by an iconic dead American 
confidante She's a mistrustful kleptomaniac research scientist who dreams of 
becoming Elvis. They fight crime!