Re: [PATCH] SMB user/password caching across shares



Alexander Larsson wrote:
Should we really check this and return before checking the actual
server_cache. If we're currently connected to the server/share using a
specific password that is not the default one, we should use that.

Lets see if i can make up an example where this breaks:

Say you connect to a server anonymously, then you later access a
specific share on that server by name (because it doesn't allow
anon). Later we need another connection to the original anon share,
but now we're gonna use the user/password instead of anon for the new
connection. As long as there is an outstanding connectiong to a
specific server/share we should always use the same user/password for
that, otherwise things like access rights etc are random depending on
which connection you happen to get.

Good point, fixed:

http://bugzilla.gnome.org/attachment.cgi?id=36479

Also:
- Fixed memory leak in lookup_user_cache
- Use cache even when user name specified in uri (when possible)

Cheers,
Nate




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]