Re: patch for 64bit compilation

[Shahms King <shahms shahms com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=4697

Was an error that GCC 2.95.2 (correctly) issued that disappeared in
3.0 <= gcc < 4.1. If it is only showing up in 64-bit builds, that's a
bug on the 32-bit side.

It will show up any place the GNOME_VFS_FILE_INFO() macros are used
without checking the return value. Well, any of them that have the form:
(value ? ((info)->flags |= FLAG_NAME) : ((info)->flags &= ~ FLAG_NAME))

which quite a few of them do. I don't have a compiler to test this on,
but if GNOME_VFS_FILE_INFO_SET_LOCAL is changed to:

#define GNOME_VFS_FILE_INFO_SET_LOCAL(info, value) \
	((info)->flags = (value ? \
	((info)->flags | GNOME_VFS_FILE_FLAGS_LOCAL) : \
	((info)->flags & ~GNOME_VFS_FILE_FLAGS_LOCAL)))

Does the error go away? The above change shouldn't change the API as the
macro still returns the new value of flags, but *should* silence the
warning.  If the above works, the rest of the macros should probably be
changed.

- --
Shahms E. King <shahms shahms com>
Multnomah ESD

Public Key:
http://shahms.mesd.k12.or.us/~sking/shahms.asc
Fingerprint:
1612 054B CE92 8770 F1EA  AB1B FEAB 3636 45B2 D75B
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFDo0zK/qs2NkWy11sRAqmfAKC9BFnA/HyrHTFKbSzpuSFzb3g5qgCgiNqg
YuJSfcRkyisw2wlRUrxtPy0=
=TQEd
-----END PGP SIGNATURE-----