Re: patch for 64bit compilation

On Thu, 2005-12-15 at 12:29 +0100, Rodrigo Moya wrote:
> On Thu, 2005-12-15 at 10:41 +0100, Alexander Larsson wrote:
> > On Wed, 2005-12-14 at 15:54 +0100, Rodrigo Moya wrote:
> > > Hi
> > > 
> > > I found a couple of compilation warnings (errors because of default VFS
> > > warning flags from jhbuild) on a 64bit machine.
> > > 
> > > Attached patch fixes it. Not sure if it should be changed for all the
> > > GNOME_VFS_FILE_INFO_SET_* macros.
> > 
> > What was the exact warning,
> >
> cc1: warnings being treated as errors
> gnome-vfs-open-fd.c: In function 'get_stat_info_from_handle':
> gnome-vfs-open-fd.c:282: warning: value computed is not used
> make[1]: *** [gnome-vfs-open-fd.lo] Error 1
> make[1]: *** Waiting for unfinished jobs....

Bah, thats a stupid warning. Its not 64bit related either. Do you use a
newer compiler or something?

Your patch actually changes the API of the macro, making it not return a
value. Maybe nobody uses that value, but I'm still hesitant to change it
for this stupid warning. So we can:
a) figure out what triggered this new stupid warning and see if we can
disable it
b) use "(void)GNOME_VFS_FILE_INFO_SET_LOCAL (file_info, TRUE);"

> >  and why didn't it appear for the other SET_*
> > macros?
> > 
> hmm, not sure, I just saw the error for those two.

Maybe its the only such macro that is used inside vfs?

 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a notorious one-eyed senator whom everyone believes is mad. She's a 
plucky wisecracking angel from the wrong side of the tracks. They fight crime! 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]