Re: [PATCH] 312707: moving a file or folder onto itself destroys it

[Tuukka Tolvanen <tuukka tolvanen gmail com>]

Tuukka Tolvanen wrote:

> The attached patch is not quite a correct fix -- when move+replacing 
> identical but separate hardlinks it fails to remove the source.

bah. I threw another candidate on bugzilla that fixes /that/ issue:
- check for directory entry name match, then
- check for directory entry namespace match (same parent fileinfo)

http://bugzilla.gnome.org/show_bug.cgi?id=312707#c3

...but then realized it's not the right solution either -- on e.g. ftp, 
we don't get any decent identifying information in file_info so the 
same-parent-folder test would be susceptible to false positives.

Besides, the same filesystem could be reachable via multiple methods at 
the same time anyhow, which renders fs entry identity comparisons pretty 
academic. Temp-renaming targets that are in the way, instead of 
deleting, seems to be the only way to really cover all the cases, that I 
can think of. Does that sound right?

't.