Re: GCC4 and building gnome-vfs

[Kjartan Maraas <kmaraas broadpark no>]

tir, 12,.04.2005 kl. 11.39 +0200, skrev Alexander Larsson: 
> On Fri, 2005-04-08 at 15:08 +0200, Kjartan Maraas wrote:
> > 
> > -unescape_character (const char *scanner)
> > +unescape_character (const gchar *scanner)
> 
> Why this change? We don't normally use gchar and gint types.
> And then you do:
> +       for (scanner = (guchar *)uri; *scanner != '\0'; scanner++, length--) {
> as if scanner was guchar.
> 
Just residue after trying out const guchar * as the arg, I'll clean it
up.

> 
> -       guchar  *base;
> -       guchar  *read_ptr;
> -       guchar  *write_ptr;
> +       gchar  *base;
> +       gchar  *read_ptr;
> +       gchar  *write_ptr;
>         gint     alloc;
> 
> same here, use char.
> 
Sure thing.

> Otherwise it seems to look ok.
> 
Thanks. Want me to post the final thing here too?

Cheers
Kjartan