Re: GCC4 and building gnome-vfs



On Fri, 2005-04-08 at 15:08 +0200, Kjartan Maraas wrote:
> 
> -unescape_character (const char *scanner)
> +unescape_character (const gchar *scanner)

Why this change? We don't normally use gchar and gint types.
And then you do:
+       for (scanner = (guchar *)uri; *scanner != '\0'; scanner++, length--) {
as if scanner was guchar.


-       guchar  *base;
-       guchar  *read_ptr;
-       guchar  *write_ptr;
+       gchar  *base;
+       gchar  *read_ptr;
+       gchar  *write_ptr;
        gint     alloc;

same here, use char.

Otherwise it seems to look ok.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a short-sighted coffee-fuelled gangster gone bad. She's a strong-willed 
psychic safe cracker from a family of eight older brothers. They fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]