Re: gnome-vfs HACKING file

[Mathieu Lacage <mathieu_lacage myrealbox com>]

On Thu, 2003-09-11 at 13:33, Mathieu Lacage wrote:
> hi all,
> 
> the gnome-vfs HACKING file in cvs HEAD says to send gnome-vfs-related
> patches to gnome-vfs gnome org  This email address is not valid though.
> Could the maintainer fix this ? Not knowing what to do with my patch, I
> am sending it here.
> 
> Originally, I wrote the attached patch which fixes a bug in
> gnome_vfs_file_info_matches: the permissions field was not correctly
> tested during matching. This caused a rather hard-to-reproduce
> timing-related bug in the nautilus permissions property dialog.
> 
> This patch is against gnome-vfs cvs HEAD. This bug is present in the
> gnome 2.4 release.
> 
> regards,
> Mathieu
-- 
Mathieu Lacage <mathieu gnu org>

? patch
? stamp-h1
? doc/gnome-vfs-2.0-decl-list.txt
? doc/gnome-vfs-2.0-decl.txt
? doc/gnome-vfs-2.0-undocumented.txt
? doc/gnome-vfs-2.0-unused.txt
? doc/gnome-vfs-2.0.args
? doc/gnome-vfs-2.0.hierarchy
? doc/gnome-vfs-2.0.signals
? doc/xml
? doc/tmpl/gnome-vfs-2.0-unused.sgml
? doc/tmpl/gnome-vfs.sgml
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/gnome-vfs/ChangeLog,v
retrieving revision 1.1609
diff -u -r1.1609 ChangeLog
--- ChangeLog	4 Jan 1997 00:38:30 -0000	1.1609
+++ ChangeLog	4 Jan 1997 04:22:26 -0000
@@ -1,3 +1,8 @@
+2003-09-11 Mathieu Lacage <mathieu gnome org>
+
+	* libgnomevfs/gnome-vfs-file-info.c: make gnome_vfs_file_info_matches
+	match the permissions too
+
 2003-09-11  Fatih Demir <kabalak gtranslator org>
 
 	* configure.in: Added "ta" (Tamil) to the languages' list.
Index: libgnomevfs/gnome-vfs-file-info.c
===================================================================
RCS file: /cvs/gnome/gnome-vfs/libgnomevfs/gnome-vfs-file-info.c,v
retrieving revision 1.22
diff -u -r1.22 gnome-vfs-file-info.c
--- libgnomevfs/gnome-vfs-file-info.c	18 Dec 2002 16:40:00 -0000	1.22
+++ libgnomevfs/gnome-vfs-file-info.c	4 Jan 1997 04:22:26 -0000
@@ -236,6 +236,7 @@
 	    || a->atime != b->atime
 	    || a->mtime != b->mtime
 	    || a->ctime != b->ctime
+	    || a->permissions != b->permissions
 	    || strcmp (a->name, b->name) != 0) {
 		return FALSE;
 	}