Re: gnome-vfs-sftp 0.1.2

[Alexander Larsson <alexl redhat com>]

On 21 Feb 2003, Bradford Hovinen wrote:

> Folks,
> 
> I just put up version 0.1.2 of the sftp method, as earlier promised.
> It's at
> http://www.math.uwaterloo.ca/~bghovinen/gnome-vfs-sftp-0.1.2.tar.gz
> 
> This version fixes several bugs, including the 'Cannot open "/"' bug and
> some difficulties with renaming files. It adds some rudimentary error
> checking (based on reading the stderr data from ssh), so failed logins
> and whatnot will get reported as such. I also incorporated the
> suggestions of Alex Larsson and others.
> 
> Please try it out if you are interested, and let me know of any
> problems. Thanks.

I got a deadlock. I think this fixes it:
--- sftp-method.c.deadlock	2003-03-05 12:28:35.000000000 +0100
+++ sftp-method.c	2003-03-05 12:30:22.000000000 +0100
@@ -1653,6 +1653,7 @@
 		if (status != SSH2_FX_OK) {
 			buffer_free (&msg);
 			g_free (write_req);
+			sftp_connection_unlock (handle->connection);
 			return sftp_status_to_vfs_result (status);
 		}
 
@@ -1752,8 +1753,10 @@
 	if (options & GNOME_VFS_FILE_INFO_FOLLOW_LINKS) {
 		res = get_real_path (conn, path, &real_path);
 
-		if (res != GNOME_VFS_OK)
+		if (res != GNOME_VFS_OK) {
+			sftp_connection_unlock (conn);
 			return res;
+		}
 	}
 	else
 		real_path = path;


The error handling when you've note got the key for the server in 
ssh-agent needs to be better too.

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's an ungodly hunchbacked ex-con who must take medication to keep him sane. 
She's a ditzy wisecracking wrestler who believes she is the reincarnation of 
an ancient Egyptian queen. They fight crime!