Re: word wrap for logview

[Emmanuele Bassi <ebassi gmail com>]

On Thu, 2008-08-28 at 23:09 +0200, David Hugh-Jones wrote:
> Heh, that's me told.
> 
> Here's an updated patch with those things fixed.
> 
> I am still not sure about the best way to deal with
> 
> > +        if (w > 100) w = w - 50; // hack to avoid the scrollbar and
> > first column
> 
> but the solution I have put in seems to be correct, and seems to work.
> Documentation is hard to find here, but see
> http://maemo.org/maemowiki/MaemoGtk210Migration to explain this line:
> 
>  taken_width = taken_width * 2; // indented rows are indented twice...

I fail to see the connection; also, the wiki page you are referring to
is targeted at the Maemo environment - which is to say an embedded
environment with a fixed screen size and a specific subset of themes.
you should not use it when targeting the desktop.

just tell me what you want to achieve with those conditions and checks,
and let's see if it is needed or can be done differently; failing that,
we can change the code to be self explanatory and add a huge comment on
top explaining why it does what it does. magic numbers *never* help.

finally: you should probably open a bug (if not already present) in
bugzilla and attach the patch there.

ciao,
 Emmanuele.

-- 
Emmanuele Bassi,
W: http://www.emmanuelebassi.net
B: http://log.emmanuelebassi.net