Re: Gedit vs icon theme

Shouldn't we just use "text-editor" if we are going to be generic?
Gnome is pretty specific. Copying the same icons over to be used in
another place, is rarely an acceptable workaround. It means that you
end up with more icons that look the same, that could mean any of a
number of things. Why can't you just change the desktop file to use
"stock_edit" instead of "gedit-icon"? I don't see why it matters if
you call it "stock_edit" or "gnome-text-editor".

If you want to be able to do fallbacks for Icon= in the desktop file
though, you should propose an extension to the menu spec, to allow it
to be a comma-separated list of strings, so that they can be tried in
order from first to last, on the xdg mailing list. I don't think it
would be difficult to get it accepted.

Unfortunately, icon themes should do a lot of things they don't
currently do. Hopefully we can get some of that fixed soon.

-- dobey

On Mon, 2004-11-01 at 09:21 +0100, Luca Ferretti wrote:
> I'm preparing a patch against gedit to use the new
> gtk_window_set_default_icon_name (const gchar *named_icon)
> My intention is to use something like
>         ...
>         gtk_window_set_default_icon_name ("gnome-text-editor");
>         ...
> Of course the gnome-text-editor.png icons are not yet in g-i-t (but
> there are stock_edit.png at 16, 24, 32 and 48  :-).
> The trouble is that currently the .desktop file uses
>         Icon=gedit-icon.png
> This entry should be updated to 
>         Icon=gnome-text-editor
> but this will break all icon themes :-( I tried 
>         Icon=stock_edit[,;]gedit-icon
> but it didn't work.
> So, waiting for GNOME 3.0 for a breakage or a desktop file specs update,
> do you think that copy stock/generic/stock_edit.png files as apps/gedit-
> icon.png is now a reasonable workaround? 
> PS Yes, I said workaround, because IMHO the icon theme should provide
> generic named icons for common application: gnome-text-editor.png is a
> generic named icon, gedit-icon.png not.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]