New filechooser icons size & 24x24 love.

[Luca Ferretti <elle uca libero it>]

Hi guys,

Is seems that the new GTK+ file chooser uses 20x20 icons.

This is very no-cool, especially 'cause gnome-icon-theme has 24x24 ones:
this means that every icon is rescaled (from 48x48 for mimetypes and
from 24x24 for folders).

The attached (lamest :-) path change sets default icon size to 24x24
pixels. I've not yet submitted it under bugzilla. IMHO there are no
usability issue, just less smooth in icons, but please try it.

Now the options are:
     1. 'force' gtk+ hackers to apply this patch and provide other 24x24
        icons (Home, Desktop and File system[1] shortcuts at least,
        eventually some mimetypes[2]) in gnome-icon-theme;
     2. provide a new entire set of 20x20 icons.

Note that today is March 9, and release date is March 22 (read: option 1
is better IMHO)

[1] Note that File system icon under computer:// and the same one in
file chooser use different icons. I don't know if this issue can be
fixed only putting a new icon somewhere or it needs some coding in
gtk+/gnome-vfs/libgnomeui

[2] Note that under g-i-t/24x24/stock/document there are some common
MIME icons i.e. stock_new-html.png for HTML files, or stock_new-text.png
for AbiWord, Word, OO.o Writer and so on files, or just stock_new.png
for gnome-fs-regular.

diff -Naur gtk+_old/gtk/gtkfilechooserdefault.c gtk+/gtk/gtkfilechooserdefault.c
--- gtk+_old/gtk/gtkfilechooserdefault.c	2004-03-09 18:50:24.000000000 +0100
+++ gtk+/gtk/gtkfilechooserdefault.c	2004-03-09 18:51:17.000000000 +0100
@@ -209,7 +209,7 @@
 
 /* Standard icon size */
 /* FIXME: this should correspond to gtk_icon_size_lookup_for_settings  */
-#define ICON_SIZE 20
+#define ICON_SIZE 24
 #define PREVIEW_HBOX_SPACING 12
 #define NUM_LINES 40
 #define NUM_CHARS 60