Re: Character limit on search entry



On 16 May 2017 at 08:56, Robert Ancell <robert ancell gmail com> wrote:
I'm looking to add a character limit to the search entry.

Seems a good idea to me.

I was going to suggest a limit of 200 characters - does that sound wrong to
anyone? I expect real searches are probably < 100 characters, but I doubled
that to be safe.

I think that even 100 chars is fine.

Unfortunately GTK+ still emits the changed signal even when the limit is
set. So the change might need to diff the last search value against the new
one to decide if it should be sent. Or should we depend on a new GTK+ for
this? I guess that would require the change to go to a stable release.

I guess change master to depend on the latest gtk, and if we need it
backporting do the search comparison locally for stable.

Richard.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]