Re: [Telepathy] Telepathy/Empathy improvements for Gnome Shell



On Mon, 2010-11-15 at 12:06 +0000, Will Thompson wrote:
> Hi,
> 
> Good point. I'd figured that this would work for the MC-crashing case, 
> but didn't see that it wouldn't work when a client crashes.
> 
> On 15/11/10 11:50, Simon McVittie wrote:
> > It wouldn't be rocket science to add the required API; I'd personally do it as
> > something like
> >
> >      ChannelDispatcher.GiveBack(o: Account, ao: Channels,
> >          x: User_Action_Time, s: Next_Handler, a{sv}: Hints) ->  nothing
> >
> > and have MC call HandleChannels on the new handler(s) itself, then return
> > success or error from GiveBack.
> 
> This sounds good to me.

Can we call it RedispatchChannel or somesuch instead of GiveBack to make
it more clear what's going on. 

Also can we use Preferred_Handler instead of Next_Handler and allow it
to be an empty string? The reason for the last request is so that
gnome-shell doesn't have to know the handler name of Empathy. It should
just be able to claim the channel as the approver point and redispatch
it to the real text handler :)

Last part of my small bike-shed, i wonder if it's worth for it to return
a ChannelRequest so it's basically really just EnsureChannelWithHints
without the request time properties. Just so all the interfaces we add
over time to ChannelRequest can be easily applied to this

-- 
Sjoerd Simons <sjoerd simons collabora co uk>
Collabora Ltd.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]