Re: No symbol 'global_get' in namespace 'Shell'

["Colin Walters" <walters verbum org>]

On Wed, Nov 26, 2008 at 12:59 PM, Sander Dijkhuis
<sander dijkhuis gmail com> wrote:
> On Wed, Nov 26, 2008 at 10:07 AM, Stuart Langridge <sil kryogenix org> wrote:
>> I've just compiled gnome-shell on Ubuntu intrepid, and on running it I
>> get the following error:
> [...]
>>    JS ERROR: !!!     message = 'No symbol 'global_get' in namespace 'Shell''
>> Window manager warning: Log level 16: Evaling main.js failed: Error:
>> No symbol 'global_get' in namespace 'Shell'
>
> Not sure, but it seems like the JavaScript API has changed, and
> scripts should use Shell.Global.get() instead of Shell.global_get()
> now. Replacing this in gnome-shell/js/ui/*.js seems to fix this error.
> Some other things like Gtk.icon_theme_get_default() in overlay.js
> should be updated too.

Duh, I should have realized this since I did the g-i work and the
patch to gjs to implement this.  I just hadn't rebuilt gjs after the
patch landed.

I've fixed up the ones you mentioned; if anyone spots any others and
has commit access feel free to jump in, otherwise ping me and I'll do
it.

Committed r86
	M	js/ui/main.js
	M	js/ui/appdisplay.js
	M	js/ui/panel.js
	M	js/ui/overlay.js
	M	js/ui/windowmanager.js
	M	js/ui/run_dialog.js
r86 = d46a5216c8ce25babc03c6f238d7006ffac3dc23 (git-svn)