Re: [gpm] better x axis ticks in gnome power manager



Hi Ivo,

You need to fork the project and then push a branch to your fork. Once
you've done that you can create a merge request against the official
master. Good luck!

Richard.

On Tue, 9 Apr 2019 at 21:12, Ivo Pletikosić <ivo pletikosic gmail com> wrote:

Hi Richard,
Thanks for getting back to me. I've tried both 'git push' and sending a merge req. by email to the address 
at that page --- neither worked. How do I get access to the repository?

These were the error messages:

"remote: You are not allowed to push code to this project.
fatal: unable to access 'https://gitlab.gnome.org/GNOME/gnome-power-manager.git/':"

"Unfortunately, your email message to GitLab could not be processed. You are not allowed to perform this 
action. If you believe this is in error, contact a staff member."

Thanks,

Ivo




On Tue, Apr 9, 2019 at 9:30 AM Richard Hughes <hughsient gmail com> wrote:

Hi Ivo,

Sorry for the late reply. I like the idea of the patch. Could you
please open a merge request here please and I'll review it:
https://gitlab.gnome.org/GNOME/gnome-power-manager/merge_requests --
could you also process the .po files like you suggest too please.
Thanks!

Richard.

On Sat, 9 Mar 2019 at 05:10, Ivo Pletikosić <ivo pletikosic gmail com> wrote:

Dear people of gnome power manager (especially Richard),
Every now and then, I check my battery charging data in gpm, and find one thing particularly annoying: 
those 10 fixed divisions of the x (time) axis. So I figured I should better do something about it, and I 
did.
My patch introduces a new graph setting divs_x that changes with the time range chosen in the combo box. 
An easy one, that I hope you'll like.
I fix a few other things that I didn't like as well:
- due to some code missing for all 5 time range options, the settings for 1 day and 1 week would be 
saved, but the combo box always showed the third option (6 hours) after a restart

- 10 minutes, 2 hrs, 6 hrs have become 30 minutes, 3 hrs, 8 hrs for the following reason: 10 minutes is 
too short, data logging happens only every 2-or-so minutes;
usual battery life seems to be something around 3 or up to 8 hours, so I thought extending these ranges 
would help us see the whole cycle
The latter changes will require some updates to the .po files, nothing that a few simple
sed -i 's/10 /30 /' *.po
sed -i 's/2 /3 /' *.po
sed -i 's/6 /8 /' *.po
cannot fix... in all but
as.po  bn_IN.po  bn.po  dz.po  en shaw po  fa.po  gu.po  he.po  ka.po  km.po  mai.po  si.po
from what I can see.


The patch is attached, do as you please. If you'd rather like this pushed onto github, I can do that as 
well.
Many thanks for a very useful little piece of software.
Best regards,
Ivo




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]