Re: Gnome Pilot 2.0.1 & Gnome Pilot Conduits 2.0.1

[Dagmar d'Surreal <dagmar speakeasy net>]

On Thu, 2003-03-13 at 04:09, Mike Markley wrote:
> On Wed, Mar 12, 2003 at 04:39:02PM -0500, JP Rosevear <jpr ximian com> wrote:
> > Gnome Pilot 2.0.1 (Relics of the past) has been released:
> 
> Still seems to have the problem with PISOCK_CFLAGS, the simplest patch
> I've come up with, for gpilotd/Makefile.am, is:
> 
> diff -u -r1.1.1.3 Makefile.am
> --- Makefile.am 8 Feb 2003 09:26:11 -0000       1.1.1.3
> +++ Makefile.am 13 Mar 2003 09:39:42 -0000
> @@ -7,7 +7,7 @@
>         -I$(top_srcdir)                                         \
>         -DG_LOG_DOMAIN=\"gpilotd\"                              \
>         -DGP_PILOT_LINK_VERSION=\"@PILOT_LINK_VERSION \"        \
> -       $(GNOME_PILOT_CFLAGS)
> +       $(GNOME_PILOT_CFLAGS) $(PISOCK_CFLAGS)
>  
>  gpmarshal.h: gpmarshal.list
>         @GLIB_GENMARSHAL@ \

Mine built fine, so this kind of raised my eyebrows.  It appears that
the addition of PISOCK_CFLAGS is somewhat unnecessary there, since those
values are being bundled into GNOME_PILOT_CFLAGS in the configure
script.

I was slightly aghast to see this in configure (and of course,
configure.in) in the top level directory:

GNOME_PILOT_CFLAGS="$GNOME_PILOT_CFLAGS -I /opt/pilot/include"
GNOME_PILOT_LIBS="$GNOME_PILOT_LIBS -L/opt/pilot/lib -lpisock -lpisync"

...probably the reason mine built was that I've got the pilot-link
library installed into /usr (definitely *not* /opt).  Since there's a
--with-pisync option to the configure script, shouldn't it be using
that?  Hardwiring it to look in /opt like that seems kinda risky to me.

Possibly now would be a good time (well, as good as any) to talk to the
chap maintaining pilot-link about adding a lil' pilot-config script or
possibly a good ol' fashioned pkg-config entry to more permanently solve
this problem.