Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0



On sön, 2016-03-13 at 22:06 -0700, Andy Lutomirski wrote:
We used to have ptmx be owned by the inner uid and gid 0.  Change
this: if the owner and group are both mapped but are not both 0,
then use the owner instead.

For container-style namespaces (LXC, etc), this should have no
effect -- UID 0 is will either be the owner or will be unmapped.

The important behavior change is for sandboxes: many sandboxes
intentionally do not create an inner uid 0.  Without this patch,
mounting devpts in such a sandbox is awkward.  With this patch, it
will just work and ptmx will be owned by the namespace owner.

Cc: Alexander Larsson <alexl redhat com>
Cc: mclasen redhat com
Cc: "Eric W. Biederman" <ebiederm xmission com>
Cc: Linux Containers <containers lists linux-foundation org>
Signed-off-by: Andy Lutomirski <luto kernel org>

Tested-by: Alexander Larsson <alexl redhat com>

Seems to work fine for me! Thanks!

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
       alexl redhat com            alexander larsson gmail com 
He's an uncontrollable voodoo librarian with a robot buddy named Sparky. 
She's a cynical winged journalist from the wrong side of the tracks. They 
fight crime! 




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]