Explanation for bugfix in CVS gmix please



Hi,

I'm looking at the ChangeLog for gmix in CVS, I found a weird "bug fix".
It's in Revision 1.36, and it's described as:

gmix.c: Fixed default mixer preferences. Bool type is 0 or 1, not "true"
or "false".

Thus the get_gui_config function was changed from:

prefs.set_mixer_on_start=gnome_config_get_bool("/gmix/startup/init");   
prefs.hide_menu=gnome_config_get_bool("/gmix/gui/menu=false");
prefs.use_icons=gnome_config_get_bool("/gmix/gui/icons=true"); 
prefs.use_labels=gnome_config_get_bool("/gmix/gui/labels=true");

to:
                                                                                    
prefs.set_mixer_on_start=gnome_config_get_bool("/gmix/startup/init=1");              
prefs.hide_menu=gnome_config_get_bool("/gmix/gui/menu=0");              
prefs.use_icons=gnome_config_get_bool("/gmix/gui/icons=1");             
prefs.use_labels=gnome_config_get_bool("/gmix/gui/labels=1");    

Now, a quick grep through the GNOME source code proved to me that every
other GNOME program uses the former method of accessing boolean
configurations. So, is this patch necessary, or even wrong? The GNOME
API docs are no help here.

Thanks,

Andrew Post



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]