Re: [PATCH] gdialog core dumps

[sopwith redhat com (Elliot Lee)]

On Wed, 24 Mar 1999 15:27:07 -0500, Jesse D . Sightler <jsight@pair.com> wrote:

>? gdialog.patch
>Index: util.c
>===================================================================
>RCS file: /cvs/gnome/gnome-utils/gdialog/util.c,v
>retrieving revision 1.4
>diff -u -r1.4 util.c
>--- util.c	1999/01/07 18:27:59	1.4
>+++ util.c	1999/03/24 20:27:25
>@@ -367,8 +367,10 @@
> 		else
> 			pspace=1;
> 	}
>-	g_free((gpointer)input); /* allocated by unquote_nl() */
>-
>+	if (!input)
>+	{
>+		g_free((gpointer)input); /* allocated by unquote_nl() */
>+	}

Since g_free() does not do anything if the pointer passed in is NULL, this
patch effectively make freeing never get done.

Doesn't make sense...
-- Elliot
Lbh'er fhccbfrq gb gel bar bs gubfr fvyyl EFN-va-guerr-yvarf .fvtangherf
ba guvf, svefg