Re: [slight bug? + patch] gnome-pager

[Peter Wainwright <prw wainpr demon co uk>]

On Tue, 02 Mar 1999 17:32:56 Mike McEwan wrote:
>   It's not completely unlikely that I'm missing some point here, but,
> when using the gnome-pager's task list to switch to a given window, I
> found I could not switch to it if it belonged to the immediately
> previous workspace??? I'm using the latest CVS sources from
> 'gnome.org'.
> 

I spotted this one before and posted a patch to the list, but
noone was listening. Don't you just replace (current_desk - 1)
by current_desk? Presumably current_desk must have been 1-based
at some time in the past and noone bothered to change this
when it became 0-based

--- gnomepager_applet.c.orig	Tue Mar  2 15:51:29 1999
+++ gnomepager_applet.c	Tue Mar  2 16:35:00 1999
@@ -506,7 +506,7 @@ client_win_show(Task *t)
   if (!t->focused)
     XSetInputFocus(GDK_DISPLAY(), t->win, RevertToPointerRoot, CurrentTime);
   XRaiseWindow(GDK_DISPLAY(), t->win);
-  if ((!t->sticky) && (t->desktop != current_desk) && (!t->iconified))
+  if ((!t->sticky) && (!t->iconified))
     gnome_win_hints_set_current_workspace(t->desktop);
   if (!t->iconified)
     {


>   The following does it for me in respect of gnomepager_applet.c:
> 
> --- gnomepager_applet.c.orig	Tue Mar  2 15:51:29 1999
> +++ gnomepager_applet.c	Tue Mar  2 16:35:00 1999
> @@ -506,7 +506,7 @@ client_win_show(Task *t)
>    if (!t->focused)
>      XSetInputFocus(GDK_DISPLAY(), t->win, RevertToPointerRoot, CurrentTime);
>    XRaiseWindow(GDK_DISPLAY(), t->win);
> -  if ((!t->sticky) && (t->desktop != current_desk - 1) && (!t->iconified))
> +  if ((!t->sticky) && (!t->iconified))
>      gnome_win_hints_set_current_workspace(t->desktop);
>    if (!t->iconified)
>      {
> 
>   I can still switch to windows that are 'iconified' - the pager
> doesn't seem to know when a window is 'sticky'. Maybe this is a
> problem with Window Maker 0.51? Maybe I'll dig further. 
> 
>   Comments/explanation/clue anyone?
> 
> -- 
> Mike.
> 
> 
> -- 
>         FAQ: Frequently-Asked Questions at http://www.gnome.org/gnomefaq
>          To unsubscribe: mail gnome-list-request@gnome.org with 
>                        "unsubscribe" as the Subject.

Peter Wainwright
Home: prw@wainpr.demon.co.uk   Work: peter.wainwright@nrpb.org.uk
http://www.wainpr.demon.co.uk
Visit the Opera Exchange Homepage at http://www.treda.co.uk/opex/