Patch for gtkicq--config.h not being included
- From: Daniel Burrows <Daniel_Burrows brown edu>
- To: gnome-list gnome org
- Subject: Patch for gtkicq--config.h not being included
- Date: Thu, 4 Feb 1999 23:01:53 -0500
I've noticed for a while now that gtkicq doesn't seem to notice when I view
the last pending message. After poking around for a little while, I discovered
that the call to update_applet() in icq_msgbox() wasn't being executed. The
reason, it seems, is that it was bracketed with #ifdef GNOME..#endif, which
would be good except that the source file didn't include the configure-generated
header which defines Gnome. This patch fixes that (and incidentally makes the
bug go away!)
I also grepped the gtkicq source directory for #ifdef GNOME and checked to see
whether they included config.h; at least gtkicq.h and response.c do not. (I
didn't check all of them) I suspect this is a bug also but I haven't
tried including config.h yet.
--
Daniel Burrows
Nothing is hopeless.
PROOF:
(a) Assume the opposite.
(b) If something _is_ hopeless, then its condition can only improve.
(c) If its condition can only improve, then there must be hope for it.
(d) Therefore, nothing is hopeless. QED.
Index: gtkfunc.c
===================================================================
RCS file: /cvs/gnome/gtkicq/src/gtkfunc.c,v
retrieving revision 1.14
diff -u -r1.14 gtkfunc.c
--- gtkfunc.c 1999/01/23 15:24:13 1.14
+++ gtkfunc.c 1999/02/05 03:57:22
@@ -8,6 +8,10 @@
immediately, as I will cease the distribution.
*******************************************************/
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
#include <stdio.h>
#include <stdlib.h>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]