Re: just some patches..

[Martin Baulig <martin home-of-linux org>]

-----BEGIN PGP SIGNED MESSAGE-----

On Wed, 27 May 1998, Timo Sirainen wrote:

> On Wed, 27 May 1998, Martin Baulig wrote:
> 
> > >  libobgnome_la_LDFLAGS = -version-info 0:0:0 -rpath $(libdir) -lobjc
> > > -libobgnome_la_LIBADD = $(GNOMEUI_LIBS) $(GNOME_LIBS) -lgtktty $(GTK_LIBS)
> > > +libobgnome_la_LIBADD = $(GNOME_LIBDIR) $(GNOMEUI_LIBS) $(GNOME_LIBS) -lgtktty $(GTK_LIBS)
> > 
> > I'm just trying to find out what exactly these patches do; on my system
> > this would be:
> > 
> > GNOMEUI_LIBS = -lgnomeui -lgnome -lgnomesupport -ldl -lgdk_imlib -ltiff
> > - -lz -ljpeg -ljpeg -lpng -lz -lSM -lICE -L/home/baulig/INSTALL/lib
> > - -L/usr/X11R6/lib -lgtk-1.1 -lgdk-1.1 -lglib-1.1 -lXext -lX11 -lm
> > 
> > GNOME_LIBS = -lgnome -lgnomesupport -ldl
> > 
> > GTK_LIBS = -lSM -lICE -L/home/baulig/INSTALL/lib -L/usr/X11R6/lib
> > - -lgtk-1.1 -lgdk-1.1 -lglib-1.1 -lXext -lX11 -lm
> > 
> > GNOME_LIBDIR = -L/home/baulig/INSTALL/lib
> > 
> > Sorry, I can't see any reason for this chunk; it seems that it throws
> > away things that are needed.
> 
> I don't have GTK libs in same dir as GNOME libs so my linker doesn't find
> gnome libs without adding that $(GNOME_LIBDIR) there..

I'm sorry. Some of the stuff went off the end of the line when I printed
your patches so I have not recogniced it.

Yes, the only thing you changed was to add $(GNOME_LIBDIR) and that's ok.
I'll apply this to CVS.

> > >  obgnome_hello_LDADD = \
> > > -       libobgnome.la ../obgtk/libobgtk.la $(GNOMEUI_LIBS) $(GNOME_LIBS) \
> > > +       libobgnome.la ../obgtk/libobgtk.la $(GNOME_LIBDIR) $(GNOMEUI_LIBS) $(GNOME_LIBS) \
> > >         -lgtktty $(GTK_LIBS) $(OBJC_LIBS) $(INTLLIBS)
> > 
> > You use $(GTK_LIBS) here, but you put them out above ?
> 
> Put out? .. Only things I've done is added that $(GNOME_LIBDIR) to start
> of both lines.

That was my fault.

> > > -INCLUDES = $(GTK_CFLAGS) $(X_CFLAGS)   \
> > > +INCLUDES = $(GNOME_INCLUDEDIR) $(GTK_CFLAGS) $(X_CFLAGS)       \
> > >            -I$(top_srcdir)              \
> > >            -I$(top_srcdir)/widgets
> ..
> > Ok, this may be reasonable.

This is already applied to CVS.

> I hate those ChangeLogs :) Hm. Some how's this:

Maybe _you_ hate them, but they're essential. It's hard for other
people to find out what has changed without this ChangeLogs. Also, if you
ommit them, other people will have to print out your patches and try to
find out what they are doing.

Please, provide a ChangeLog entry and when you send patches, please tell
what they're doing - you really make us life much easier !

gnome-objc/ChangeLog:

1998-05-27  Timo Sirainen <a@sicom.fi>

	* Makefile.am (libobgnome_la_LDFLAGS, obgnome_hello_LDADD):
	added $(GNOME_LIBDIR) for people having gtk+ and gnome in
	different directories.

Thanks,

Martin

- -----------------------------------------------------------------
   Martin Baulig - Angewandte Mathematik - Universitaet Trier

   baulig@castor.uni-trier.de, http://www.home-of-linux.org/
   Key: 1024-bit key with ID C8178435 created 1997/01/24 
   ID:  67 C1 84 A0 47 F5 11 C5  5F 68 4C 84 99 05 C3 92
   Finger me for public key or fetch finger.txt from the url above
- ------------------------------------------------------------------



-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: noconv

iQCVAwUBNWv7tIA8K7jIF4Q1AQH8uwQAvuXouAxN8s1+K2f6T52idUoW3mIxyepB
YdEg511zst3UcE5VXjQGlPT+3tPgLg25taD5xZstf0UBk8GxO/zaQP3cceddEAVp
hj14JU3XjYYSwEyBwCnHbv7CGPREzZRBNM9D85D11CSDPSrZWxekqA9B6RP7CysS
DfLoKmZWMMg=
=sBm1
-----END PGP SIGNATURE-----