Re: just some patches..

[Martin Baulig <martin home-of-linux org>]

-----BEGIN PGP SIGNED MESSAGE-----

On Tue, 26 May 1998, Timo Sirainen wrote:

> diff -ru /home/aaaaaa/cvs/gnome/gnome-objc/obgnome/Makefile.am gnome-objc/obgnome/Makefile.am
> --- /home/aaaaaa/cvs/gnome/gnome-objc/obgnome/Makefile.am       Tue May 26 15:39:25 1998
> +++ gnome-objc/obgnome/Makefile.am      Tue May 26 17:35:21 1998
> @@ -87,7 +87,7 @@
> 
> 
>  libobgnome_la_LDFLAGS = -version-info 0:0:0 -rpath $(libdir) -lobjc
> -libobgnome_la_LIBADD = $(GNOMEUI_LIBS) $(GNOME_LIBS) -lgtktty $(GTK_LIBS)
> +libobgnome_la_LIBADD = $(GNOME_LIBDIR) $(GNOMEUI_LIBS) $(GNOME_LIBS) -lgtktty $(GTK_LIBS)

I'm just trying to find out what exactly these patches do; on my system
this would be:

GNOMEUI_LIBS = -lgnomeui -lgnome -lgnomesupport -ldl -lgdk_imlib -ltiff
- -lz -ljpeg -ljpeg -lpng -lz -lSM -lICE -L/home/baulig/INSTALL/lib
- -L/usr/X11R6/lib -lgtk-1.1 -lgdk-1.1 -lglib-1.1 -lXext -lX11 -lm

GNOME_LIBS = -lgnome -lgnomesupport -ldl

GTK_LIBS = -lSM -lICE -L/home/baulig/INSTALL/lib -L/usr/X11R6/lib
- -lgtk-1.1 -lgdk-1.1 -lglib-1.1 -lXext -lX11 -lm

GNOME_LIBDIR = -L/home/baulig/INSTALL/lib

Sorry, I can't see any reason for this chunk; it seems that it throws
away things that are needed.

> @@ -95,5 +95,5 @@
>         obgnome-hello.m
> 
>  obgnome_hello_LDADD = \
> -       libobgnome.la ../obgtk/libobgtk.la $(GNOMEUI_LIBS) $(GNOME_LIBS) \
> +       libobgnome.la ../obgtk/libobgtk.la $(GNOME_LIBDIR) $(GNOMEUI_LIBS) $(GNOME_LIBS) \
>         -lgtktty $(GTK_LIBS) $(OBJC_LIBS) $(INTLLIBS)

You use $(GTK_LIBS) here, but you put them out above ?

> diff -ru /home/aaaaaa/cvs/gnome/gnome-admin/gxsnmp/widgets/Makefile.am gnome-admin/gxsnmp/widgets/Makefile.am
> --- /home/aaaaaa/cvs/gnome/gnome-admin/gxsnmp/widgets/Makefile.am       Thu May 7 22:53:14 1998
> +++ gnome-admin/gxsnmp/widgets/Makefile.am      Tue May 26 17:35:01 1998
> @@ -12,7 +12,7 @@
> 
>  libgtkext_la_LDFLAGS = -version-info 1:0:0
> 
> -INCLUDES = $(GTK_CFLAGS) $(X_CFLAGS)   \
> +INCLUDES = $(GNOME_INCLUDEDIR) $(GTK_CFLAGS) $(X_CFLAGS)       \
>            -I$(top_srcdir)              \
>            -I$(top_srcdir)/widgets

GTK_CFLAGS = -I/home/baulig/INSTALL/lib/glib/include
- -I/home/baulig/INSTALL/include -I/usr/X11R6/include

GNOME_INCLUDEDIR = -I/home/baulig/INSTALL/include -DNEED_GNOMESUPPORT_H
- -I/home/baulig/INSTALL/lib/gnome-libs/include 
- -I/home/baulig/INSTALL/lib/glib/include -I/home/baulig/INSTALL/include
- -I/usr/X11R6/include

GTK_CFLAGS = -I/home/baulig/INSTALL/lib/glib/include
- -I/home/baulig/INSTALL/include -I/usr/X11R6/include

Ok, this may be reasonable.

Well, in general patches should only be applied is there's any actual
reason for them - could you please be a little more specific about this
and also provide a ChangeLog entry ?

Thanks,

Martin

- -----------------------------------------------------------------
   Martin Baulig - Angewandte Mathematik - Universitaet Trier

   baulig@castor.uni-trier.de, http://www.home-of-linux.org/
   Key: 1024-bit key with ID C8178435 created 1997/01/24 
   ID:  67 C1 84 A0 47 F5 11 C5  5F 68 4C 84 99 05 C3 92
   Finger me for public key or fetch finger.txt from the url above
- ------------------------------------------------------------------


-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: noconv

iQCVAwUBNWu1hoA8K7jIF4Q1AQHX6QP+NXT8VZ5+1aTuOSHMRVwp7u+tAMGeSDGR
tWakxWUL7mLndLB6hlc4Mj9goLp1lmqwq5JA0QqAsaCmqb+9Cy3A38u8tzmvGd1a
dhpnekU++FZAd/2HEPBy7jVYNN2jmRruP43aDpO4Gb2gRZKq/d6sXNKjmsmAEure
/uOQuoUsZS8=
=bxMQ
-----END PGP SIGNATURE-----