Various bugs in gnome-core (all core developers should read this)

[Jason Tackaberry <tack dok org>]

I decided to go through the applets and jot down some of the odd behaviour
I noticed and think should be corrected before v1.0.  gnome-libs and gnome-core
is from CVS 11/16 17:00.

An applet dying core dumps the panel?
-------------------------------------

It seems that applets that misbehave are able to easily crash the panel.  I
think the panel should be resiliant to errant applets.  The output from
panel is usually something like:

   ** CRITICAL **: file panel-widget.c: line 449 (panel_widget_is_applet_stuck):
   assertion `applet!=NULL' failed.  2 3 4

   Gdk-ERROR **: BadWindow (invalid Window parameter)
     serial 2092 error_code 3 request_code 10 minor_code 0

   aborting...
   Aborted (core dumped)


Various strange applet behaviour
--------------------------------

If an applet cannot be loaded, panel should display an error.  

Applets that need to report errors should use a message box, not an ouput to
stderr.  Some of these are:
	- batmon_applet
	- modemlights_applet
	- drivemount_applet

The applets listed below had problems loading from the Add Applet menu, but
seemed to load fine by running explicitely from the prompt.  No error message
was displayed by panel, and there was no other indication of a problem.  One
thing to mention is that a small separator did show up on the panel:
	- batmon_applet
	- battery_applet
	- webcontrol_applet
	- gnomepager_applet


Specific applet bugs
--------------------

gnomepager_applet: 
	- The right-click menu is very hard to get at.  It should be available if
	  you click anywhere within the applet.
   - Bug with metal theme; doesn't draw miniature window boxes.  Outputs:
      ** CRITICAL **: file metal_theme_draw.c: line 1191 (draw_box): assertion 
      `widget != NULL' failed.
   - When I ran it manually, it wouldn't draw until I moved the panel.  (Seems
     to be Metal theme related.)


cdplayer_applet:
   - also has problems with metal theme:
      Gdk-CRITICAL **: file gdkdraw.c: line 373 (gdk_draw_pixmap): assertion 
      `gc != NULL' failed.

      Gdk-CRITICAL **: file gdkdraw.c: line 82 (gdk_draw_rectangle): assertion 
      `gc != NULL' failed.


mixer_applet:
   - Flickers badly.  If you can't fix the flickering, I think you should get
     rid of the sliding color change.


Mailcheck applet (gen_util_applet):
   - Does it even work?  Tested it many times and couldn't get it to work.
	- It should probably support POP3.


dialer_applet:
   - How does one configure this thing?  It seems rather useless and
     confusing.  Perhaps some more effort should be put into it.
   - superceded by modemlights_applet?


netload_applet:
   - doesn't save properties when you remove it
   - Device name seems to dissappear when you check properties again.
   - Sometimes the properties option doesn't do anything.


printer_applet:
   - What does this thing do?


asclock_applet:
   - This thing crashes and brings the panel down with it.  A backtrace:

#0  0x404be66d in __libc_free (mem=0x8091100) at malloc.c:2866
#1  0x400b1c81 in g_free () at gmem.c:680
#2  0x400b1094 in g_main_poll (timeout=42, use_priority=0, priority=0)
    at gmain.c:630
#3  0x400b0c1a in g_main_iterate (block=1, dispatch=1) at gmain.c:465
#4  0x400b0e49 in g_main_run () at gmain.c:525
#5  0x402de339 in gtk_main () at gtkmain.c:410
#6  0x400118fd in applet_widget_gtk_main () at applet-widget.c:760


wmpager_applet:
	- sigsegvs also, and the panel dies.

Program received signal SIGSEGV, Segmentation fault.
get_current_workspace () at wmpager_applet.c:280
280         return wws+1;
(gdb) bt
#0  get_current_workspace () at wmpager_applet.c:280
#1  0x80495f6 in main (argc=1, argv=0xbffff964) at wmpager_applet.c:65


clockmail_applet:
   - As with the other mail checker, I couldn't get this to detect new mail (I
     tested it several times).  I wonder if the fact that my Mailbox is on an
     NFS mount has to do with the problem.
   - The default look is quite hideous.


esdmanager_applet:
   - This thing does nothing.  It loads and a separator gets shoved into
     the panel, but has no display.  What is it supposed to do?


Miscellaneous things worth mentioning
-------------------------------------

- GTK+ pixmap theme seems slower than it used to be, particulary in notebook
  widgets.  
- When using gnome-session, panel settings don't seem to be retained.


If you need more specific details about any of these notes, let me know.  I
will keep reporting bugs as I find them.

Happy hunting,
Jason.