gnome-keyring Probable boolean logic error



Seems pretty straightforward. I found this with Coccinelle.

Thanks,
Michael


--- daemon/ssh-agent/gkd-ssh-agent.c
+++ /tmp/cocci-output-18531-5ef60c-gkd-ssh-agent.c
@@ -86,7 +86,7 @@ write_all (int fd, const guchar *buf, in
 
                res = write (fd, buf, len);
                if (res < 0) {
-                       if (errno == EAGAIN && errno == EINTR)
+                       if (errno == EAGAIN || errno == EINTR)
                                continue;
                        if (errno != EPIPE)
                                g_warning ("couldn't write %u bytes to client: %s", all,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]