gnome-keyring Starting review process for



In order to get better code quality in gnome-keyring, I've been thinking
it would be useful to start up a sort of code review process before new
features are merged. Initially this would be a sort of informal review
process.

I'll be putting new features to bugzilla with the following:

 * URL to branch with new feature.
 * Patch with the new feature.

Then I'll send an email to this list, asking for reviewers. Reviewers
would check for any problems with code sanity, security issues, mistakes
etc... The goal being to get another set of eyes over the code before
merging it.

If there's no reviewers for something, then I guess after a timeout
we'll need to see about merging it anyway. We could fine tune things
after we have a bit of experience with how it works.

How does that sound?

Cheers,

Stef


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]