Re: gnome-keyring Removing GCC-specific hack from



Hi Stef,

* Stef Walter <stef-list memberwebs com> wrote:
> Ed Schouten wrote:
> > I was just trying to compile gnome-keyring with Clang (from the LLVM
> > project) and it seems it doesn't support this construct (which makes
> > a lot of sense in my opinion):
> > 
> > 	const int i = 5;
> > 	union {
> > 		char foo[i];
> > 	} bar;
> 
> I'm no standards lawyer, but I thought modern C's could use any constant
> for an array initializer...

Yeah, I think Clang should also support this for constants. I think I'll
file a bug report about this one of these days.

> > The attached patch makes gnome-keyring build with Clang. This is
> > actually the first package I'm seeing that actually uses this construct
> > (nowhere used in FreeBSD, Xorg, etc).
> 
> Nevertheless, I've committed the patch. BTW, I follow Clang progress
> avidly. It's an awesome project.

Thanks!

-- 
 Ed Schouten <ed 80386 nl>
 WWW: http://80386.nl/

Attachment: pgpIuPPbIwCnB.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]