[Bug 744984] New: Cleanup of of modules/puppet/manifests/init.pp according to puppet-lint

["sysadmin" (GNOME Bugzilla) <bugzilla gnome org>]

Bug ID	744984
Summary	Cleanup of of modules/puppet/manifests/init.pp according to puppet-lint
Classification	Infrastructure
Product	sysadmin
Version	unspecified
OS	Linux
Status	UNCONFIRMED
Severity	normal
Priority	Normal
Component	Apprentices
Assignee	sysadmin-maint@gnome.bugs
Reporter	bugzilla@peter-baumgarten.com
QA Contact	sysadmin-maint@gnome.bugs
GNOME version	---

Created attachment 297604 [details] [review]
Patch of changes made to modules/puppet/manifests/init.pp

Cleanup of file according to puppet-lint errors and warnings

before:
puppet-lint modules/puppet/manifests/init.pp
WARNING: unquoted file mode on line 82
WARNING: unquoted file mode on line 98
WARNING: double quoted string containing no variables on line 73
WARNING: double quoted string containing no variables on line 74
WARNING: double quoted string containing no variables on line 78
WARNING: double quoted string containing no variables on line 85
WARNING: double quoted string containing no variables on line 89
WARNING: double quoted string containing no variables on line 92
WARNING: double quoted string containing no variables on line 92
WARNING: double quoted string containing no variables on line 125
WARNING: double quoted string containing no variables on line 126
WARNING: double quoted string containing no variables on line 127
WARNING: double quoted string containing no variables on line 129
WARNING: double quoted string containing no variables on line 132
WARNING: double quoted string containing no variables on line 133
WARNING: double quoted string containing no variables on line 134
WARNING: double quoted string containing no variables on line 135
ERROR: puppet::client not in autoload module layout on line 1
ERROR: puppet::master not in autoload module layout on line 47
ERROR: add_hiera_puppet_files not in autoload module layout on line 106
WARNING: indentation of => is not properly aligned on line 27
WARNING: indentation of => is not properly aligned on line 95
WARNING: indentation of => is not properly aligned on line 118
WARNING: indentation of => is not properly aligned on line 119
WARNING: indentation of => is not properly aligned on line 121
WARNING: indentation of => is not properly aligned on line 122
WARNING: indentation of => is not properly aligned on line 126
ERROR: tab character found on line 2
ERROR: tab character found on line 3
ERROR: tab character found on line 4
ERROR: tab character found on line 12
ERROR: tab character found on line 13
ERROR: tab character found on line 14
ERROR: tab character found on line 15
ERROR: tab character found on line 16
ERROR: tab character found on line 17
ERROR: tab character found on line 18
ERROR: tab character found on line 20
ERROR: tab character found on line 21
ERROR: tab character found on line 22
ERROR: tab character found on line 23
ERROR: tab character found on line 24
ERROR: tab character found on line 25
ERROR: tab character found on line 26
ERROR: tab character found on line 28
ERROR: tab character found on line 29
ERROR: tab character found on line 51
ERROR: tab character found on line 52
ERROR: tab character found on line 53
ERROR: tab character found on line 74
ERROR: tab character found on line 75
ERROR: tab character found on line 76
ERROR: tab character found on line 79
ERROR: tab character found on line 83
ERROR: tab character found on line 95
ERROR: tab character found on line 100
ERROR: tab character found on line 116
ERROR: tab character found on line 117
ERROR: tab character found on line 118
ERROR: tab character found on line 119
ERROR: tab character found on line 120
ERROR: tab character found on line 121
ERROR: tab character found on line 122
ERROR: tab character found on line 123
ERROR: tab character found on line 125
ERROR: tab character found on line 126
ERROR: tab character found on line 127
ERROR: tab character found on line 128
ERROR: tab character found on line 129
ERROR: tab character found on line 129
ERROR: tab character found on line 130
ERROR: tab character found on line 132
ERROR: tab character found on line 133
ERROR: tab character found on line 134
ERROR: tab character found on line 134
ERROR: tab character found on line 135
ERROR: tab character found on line 136
WARNING: line has more than 80 characters on line 102
WARNING: line has more than 80 characters on line 109
WARNING: class not documented on line 1
WARNING: class not documented on line 47
WARNING: defined type not documented on line 106
WARNING: mode should be represented as a 4 digit octal value or symbolic mode
on line 82
WARNING: mode should be represented as a 4 digit octal value or symbolic mode
on line 98
WARNING: unquoted resource title on line 52
WARNING: unquoted resource title on line 56
WARNING: unquoted resource title on line 57
WARNING: unquoted resource title on line 58
WARNING: unquoted resource title on line 59
WARNING: unquoted resource title on line 117
ERROR: two-space soft tabs not used on line 2
ERROR: two-space soft tabs not used on line 4
ERROR: two-space soft tabs not used on line 12
ERROR: two-space soft tabs not used on line 18
ERROR: two-space soft tabs not used on line 20
ERROR: two-space soft tabs not used on line 29
ERROR: two-space soft tabs not used on line 51
ERROR: two-space soft tabs not used on line 53
ERROR: two-space soft tabs not used on line 76
ERROR: two-space soft tabs not used on line 83
ERROR: two-space soft tabs not used on line 100
ERROR: two-space soft tabs not used on line 116
ERROR: two-space soft tabs not used on line 118
ERROR: two-space soft tabs not used on line 119
ERROR: two-space soft tabs not used on line 120
ERROR: two-space soft tabs not used on line 121
ERROR: two-space soft tabs not used on line 122
ERROR: two-space soft tabs not used on line 123
ERROR: two-space soft tabs not used on line 125
ERROR: two-space soft tabs not used on line 130
ERROR: two-space soft tabs not used on line 132
ERROR: two-space soft tabs not used on line 136
ERROR: trailing whitespace found on line 27
ERROR: trailing whitespace found on line 35
ERROR: trailing whitespace found on line 51
WARNING: defined type defined inside a class on line 106
WARNING: ensure found on line but it's not the first attribute on line 75
WARNING: ensure found on line but it's not the first attribute on line 128
WARNING: variable not enclosed in {} on line 107
WARNING: variable not enclosed in {} on line 109
WARNING: variable not enclosed in {} on line 109
WARNING: variable not enclosed in {} on line 109
WARNING: case statement without a default case on line 31

after:
ERROR: puppet::client not in autoload module layout on line 1
ERROR: puppet::master not in autoload module layout on line 47
ERROR: add_hiera_puppet_files not in autoload module layout on line 117
WARNING: line has more than 80 characters on line 113
WARNING: line has more than 80 characters on line 118
WARNING: line has more than 80 characters on line 120
WARNING: class not documented on line 1
WARNING: class not documented on line 47
WARNING: defined type not documented on line 117
WARNING: mode should be represented as a 4 digit octal value or symbolic mode
on line 91
WARNING: mode should be represented as a 4 digit octal value or symbolic mode
on line 109
WARNING: defined type defined inside a class on line 117
WARNING: case statement without a default case on line 31

---

      You are receiving this mail because:

• You are watching the QA Contact of the bug.
• You are watching the assignee of the bug.