[Bug 744341] puppet-lint fixes to sysadmins manifest



Comment # 3 on bug 744341 from Joey Stanford
(In reply to matanya from comment #2)
> -1 here. changing 'true' to true is technically correct, but can cause
> chaos, since you are changing the type of the object from string to bool. If
> the original comparison was string based, it will break. Did you verify it?

Thanks for the review. There are two instances of this in the tree, the one
here and also ostree/manifests/init.pp.  The docs on the internet all indicate
that managehome should be unquoted but they are quoted in these branches.

puppet --debug --verbose test.pp    returns no errors
puppet parser validate init.pp     returns no errors

I was unable to get a dryrun ("puppet agent --test --noop") to work though:
"err: Could not request certificate: The certificate retrieved from the master
does not match the agent's private key."  The help text asks me to "puppet cert
clean bastion.gnome.org" which I do not want to attempt.

Thoughts?


You are receiving this mail because:

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]