What | Removed | Added |
---|---|---|
Status | NEEDINFO | RESOLVED |
Resolution | --- | FIXED |
Merged [1]. A few notes though: 1. Make sure the call to the function is correctly specified. [2] 2. Make sure to follow the Puppet guidelines listed at [3] (puppet-lint's use is suggested) 3. Make sure to not name the resource call with the same name (previously $name was set to be $id on the acl class, I fixed that as multiple calls to the acl functions were going to collide when used on the same manifest [4]) 4. The relevant file for including the change was modules/puppet/master.pp as that's where /etc/puppet usually resides Thanks for your contribution! [1] https://infrastructure.gnome.org/browse/puppet/commit/?id=133da7714e0ee9eee3cc5a1ea9efeb98fc37d1a7 [2] https://infrastructure.gnome.org/browse/puppet/tree/modules/puppet/manifests/master.pp?id=c5df27abf540982481357db663d78cac227e95f9#n115 [3] https://wikitech.wikimedia.org/wiki/Puppet_coding#Coding_Style [4] https://infrastructure.gnome.org/browse/puppet/commit/?id=c5df27abf540982481357db663d78cac227e95f9