[Bug 634426] Disallow tags named HEAD



https://bugzilla.gnome.org/show_bug.cgi?id=634426
  sysadmin | Git | unspecified

--- Comment #1 from Krzesimir Nowak <qdlacz gmail com> 2011-10-31 12:21:31 UTC ---
Created an attachment (id=200329)
 View: https://bugzilla.gnome.org/attachment.cgi?id=200329
 Review: https://bugzilla.gnome.org/review?bug=634426&attachment=200329

Allows deleting HEAD tags.

Rejecting creation of tag named HEAD is implemented as I see in line 176 [1].
But it would be useful to allow deleting tags named HEAD. There are probably
some projects that have such tag (e.g. file-roller). The attached patch changes
a logic a bit to achieve this. It would be good to test it on some dummy git
repository. I tested it by direct calling:

./pre-receive-check-policy 321 000 refs/tags/HEAD (printed nothing and returned
0)

and

./pre-receive-check-policy 321 000 refs/tags/foo (printed a warning and
returned 1)

[1] http://git.gnome.org/browse/gitadmin-bin/tree/pre-receive-check-policy#n176

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the QA contact of the bug.
You are watching the assignee of the bug.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]