[Bug 599066] Create a specific check for the gnomeweb user from l10n.gnome.org

["sysadmin" (bugzilla.gnome.org) <bugzilla gnome org>]

https://bugzilla.gnome.org/show_bug.cgi?id=599066
  sysadmin | Git | unspecified

Owen Taylor <otaylor> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #173458|none                        |needs-work
             status|                            |

--- Comment #15 from Owen Taylor <otaylor redhat com> 2010-10-29 20:07:18 UTC ---
Review of attachment 173458:
 --> (https://bugzilla.gnome.org/review?bug=599066&attachment=173458)

Main problem I have with this is that I don't think we should be recyclign the
gnomeweb user for this. Otherwise comments are pretty superficial.

::: create-auth
@@ +29,3 @@
 GNOMECVS=0
 GNOMEGIT=0
+GNOMEWEB=0

GNOMEWEB isn't at all like the other variables or options here, this would have
to be GNOMEWEB_USER or something.

But I don't like using the gnomeweb user for this. gnomeweb is about editing
web config, viewing web logs, etc. Doesn't seem like it should be in the same
permissions bucket as "committing translations changes to Git" .... I don't see
any real connection other than that the process is running as gnomeweb (is it?)
on l10n.gnome.org. I would expect a separate user 'translations' or something.

@@ +130,3 @@

+    if not GNOMEWEB and "gnomeweb" in users:
+        users.remove('gnomeweb')

Probably harmless, but makes no "code sense" to me

@@ +184,3 @@
                     #file.write ("command=\"/usr/bin/cvs
server\",no-pty,no-port-forwarding ")
+                    if GNOMEWEB and user['uid'] == "gnomeweb":
+                        file.write
("command=\"/home/admin/bin/run-git-or-special-cmd\",no-pty,no-port-forwarding,host=\"boron.canonical.com,91.189.93.2\"
")

Belt and suspenders doesn't make sense to me - either host or IP, why both?

@@ +257,3 @@
+    if '--gnomeweb-hack' in group_list:
+        GNOMEWEB=1
+        group_list = filter (lambda x: x != '--gnomeweb-hack', group_list)

What's a hack about it?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the QA contact of the bug.
You are watching the assignee of the bug.