Re: A couple git commit mail issues [plus another]

>>>>> "Christian" == Christian Persch <chpe gnome org> writes:

Christian> for file moves, the diff contains both the complete old file
Christian> (-'d) and the complete new file (+'d), making the commit
Christian> mails a) very large,

Using the -C and -M flags to git diff, et al will fix that issue. made that change after I suggested it; it went over well
with the lkml devs.

Christian> diffs are also sent out for changes to po/*.po while svn
Christian> commit mails omits the diff for these

IMHO, if these are filtered out, they should be a separate list rather
than just dumped.  Or, alternatively, changes to such files could be
replaced with the cgit url showing said change.

In addition to the above, I've noticed that some of the commit notices
have left off the X-Topics: header.  Using only Keywords: isn't awful,
but for filtering it would be better to have a header which is defined
to always specify the repo.  Maybe something like X-Git-Repo: could be

James Cloos <cloos jhcloos com>         OpenPGP: 1024D/ED7DAEA6

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]