Re: Boxes: string breaks

[Alexandre Franke <alexandre franke gmail com>]

On Mon, Sep 14, 2015 at 8:54 PM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> I asked as soon as I had the patch and not long after I knew how I'm
> going to solve this in the end (i-e when I knew how strings will be
> effected).

I wasn't blaming you for waiting, I was just stating the fact that now
is not the best time to introduce new strings.

> I provided a link to attachment. I would have done a better job if I
> didn't realize this is coming in very late.

My point is if you're asking for something, you better make a good case for it.

Let me try to remove the noise from your pasted patch and see if I get
this right.

Adding:
> #. Translators: First '%s' is name of box and second one is it's
> status (e.g 'connecting...')
> msgid "%s: %s"

Replacing
> #. Translators: The %s will be expanded with the name of the vm
> msgid "Restoring %s from disk"
with
> #. Translators: Shown when restoring a box from a saved state
> #: ../src/libvirt-machine.vala:588
> msgid "Restoring state…"


Replacing
> #. Translators: The %s will be expanded with the name of the vm
> msgid "Starting %s"
with
> #. Translators: Shown when starting a box
> #: ../src/libvirt-machine.vala:591
> msgid "Starting…"

Replacing
> #. Translators: The %s will be expanded with the name of the vm
> msgid "Connecting to %s"
with
> #. Translators: This is shown when connecting to a box
> msgid "Connecting…"

Summary: 4 new strings.


> > nor explain why we should grant you an
> > exception,
>
> Same reason and I see a few other issues I really should fix before
> code freeze. You can find the rationale on the bug description:

The question is not only "what are you changing/adding?" but also "can
you tell us why this is important to get in now rather than in the
next release?". In other words, please justify why you think an
exception is needed.


> "Unifying 'status' of machines caused some issues and the one that's
> not yet resolved is us showing "Connecting to '%s'" and "Restoring
> '%s'" in collection views, where it doesn't completely fit in the
> available space usually and also it looks odd given that name of the
> machine is already shown in the context and is clear to user.

Let me check if I get this right: the issue is that the English string
doesn't fit in the allocated space? In this case, do you really thing
just changing the strings is the correct way to handle this? Remember
that you're talking to translators here and what works with the
original strings in English might not work in other languages. You
can't reasonably expect that because the English string is short, the
translation will always be as short, and you should handle in your
code the fact that the string may need more space to be displayed
correctly.

-- 
Alexandre Franke