Re: PO file checks on git.gnome.org

[Andre Klapper <ak-47 gmx net>]

On Fri, 2014-08-01 at 12:56 +0200, Olav Vitters wrote:
> On Fri, Aug 01, 2014 at 11:50:01AM +0200, Andre Klapper wrote:
> > On Mon, 2014-07-28 at 22:42 +0200, Olav Vitters wrote:
> > > 2. Keyword header in .desktop files were sometimes translated without
> > >    ending in a semicolon. The server now checks for this. The check is
> > >    fairly simple, so could be that it isn't working right.
> >
> > Uhm, just realizing that the check is also triggered when the msgstr is
> > empty (e.g. translation team has not translated 100% yet).  :-/
>
> Can you give me an example po file please? Then I'll fix it up.

I was wrong: It's not about empty translations but translation strings
that are so long that the po file breaks lines and starts with
   msgstr ""
instead, which also triggers the commit hook and is worse.

For example: gnome-control-center/po/sl.po 

$:andre\> git commit -m "Fix broken translation of keywords to Slovenian" po/sl.po 
[master ca8792f] Fix broken translation of keywords to Slovenian
 1 file changed, 1 insertion(+), 1 deletion(-)
$:andre\> git push
Counting objects: 29, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 398 bytes | 0 bytes/s, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: The following translation (.po) file should ensure the translated content ends with a semicolon. 
(When updating branch 'master'.)
remote: 
remote: po/sl.po
remote: 
remote: The following part of the file fails to do this. Please correct the translation and try to push again.
remote: 
remote: #: ../panels/background/gnome-background-panel.desktop.in.in.h:4
remote: msgid "Wallpaper;Screen;Desktop;"
remote: msgstr "Slika ozadja;Zaslon;Namizje"
remote: #: ../panels/mouse/gnome-mouse-panel.desktop.in.in.h:4
remote: msgid "Trackpad;Pointer;Click;Tap;Double;Button;Trackball;Scroll;"
remote: msgstr ""
remote: #: ../panels/sound/data/gnome-sound-panel.desktop.in.in.h:4
remote: msgid "Card;Microphone;Volume;Fade;Balance;Bluetooth;Headset;Audio;"
remote: msgstr ""
[...]

andre
-- 
Andre Klapper  |  ak-47 gmx net
http://blogs.gnome.org/aklapper/