Music: Freeze Break request

["Arnel A. Borja" <kyoushuu yahoo com>]

Hi,

We know this is late, but we would like to merge more features to Music 
for this
cycle, 3.10. Music is a preview release this cycle, and doesn't have much
features, so we would like to add more to make it more usable. Because 
of that,
we would like to request for UI and String Freeze Break for the 
following new
features:

* Notifications
* Search
* Playlists

Also, a string freeze break is needed by this bug, which changes the 
accelerator
for the application menu item "Now Playing" (clash with "New Playlist", they
both use N as accelerator; "Now Playing" will now use P as accelerator):
https://bugzilla.gnome.org/show_bug.cgi?id=707590


Notifications
=============

This is the most tested of the three and was already approved for String 
Freeze
Break. It is for showing the notifications at the message tray, also adds an
icon there to control Music, and adds controls to the lock screen too so you
could access Music without unlocking. We was not able to merge this 
before the
freeze because of a libnotify bug blocking it.

I added this here too because no one rejected nor accepted this feature 
for UI
Freeze Break in the previous request.


Search
======

This one is not yet implemented according to the mockups, it is just 
filtering
for now in this cycle, but very convenient when searching for some 
songs, albums
or artists on large music collections. This has been sitting for a long 
time now
in a git branch, but wasn't completed until just recently because we 
were busy
fixing bugs.

As this is just filtering, it is not a huge change - we just added a 
search bar
and wrapped the models with GtkTreeModelFilter.

As far as I could remember, this won't add nor change any strings, so it 
only
needs a UI Freeze Break.


Playlists
=========

This helps managing songs easier, so we would like to have this on this 
cycle
too. It is now fully working except on removing songs on a playlist and 
needs
some style fixes (borders, menu alignment, checkbox positioning, etc.) 
to fully
follow the mockups.

We have to move to totem-pl-parser from using grilo to parse playlists, 
that's
why it wasn't completed before the freeze. Needs UI and String Freeze Break.

Strings added:
- "Playlists" (name of the view)
- "%d Song", "%d Songs" (shows the number of songs when a playlist is 
selected)
- "New Playlist", "Select Playlist", "Select" (in Add To Playlist dialog)
- "_Play", "_Delete" (playlist menu)
- "Remove from Playlist" (action button in Playlists view, selection 
mode, not
  yet added though)
- We might add an additional message when no playlist is selected yet

The branch for this feature has lots of commits, but they are actually 
smaller
than they look, they are separated this way to make it easier to rebase.


All three features and the bug report are approved and tested by the
maintainers.

We are providing packages for Fedora 19, openSUSE 12.3 and Arch Linux to let
more people test these features (Music is backwards-compatible to 3.8 
for this
cycle, except that it needs the latest libnotify release), and the 
packages are
in https://build.opensuse.org/project/show/home:arnelborja:gnome-music:git

As for now, the Music team are the people who tested it, and probably 
users of
our OBS repository. I use these features everyday since Music is my default
music player (in Fedora 19 and openSUSE 12.3, using the packages from 
the OBS
repository), and I haven't encountered any crashes.

Screenshots for these features are in
http://kyoushuu.wordpress.com/2013/09/11/gnome-music-notifications-search-and-playlists/
and the git branch is in 
https://git.gnome.org/browse/gnome-music/log/?h=freeze-break


Regards,

Arnel A. Borja