Re: Boxes string freeze break request

[Gabor Kelemen <kelemeng gnome hu>]

2012-09-18 19:43 keltezéssel, Gil Forcada írta:
> El dt 18 de 09 de 2012 a les 11:50 +0200, en/na Christophe Fergeau va
> escriure:
> > Hey,
> >
> > I'd like to request a very late string freeze break for code that I'd like
> > to get into Boxes 3.5.92. This is to fix bug
> > https://bugzilla.gnome.org/show_bug.cgi?id=684224, which causes Boxes to
> > seem to be hung in some error situations.
> >
> > The first patch in this bug adds one new string _("Connection to '%s'
> > failed") which will only appear in the UI when an error occurs after
> > clicking on a box in the collection view to try to connect to it. It will
> > not be user visible when all goes well.
> >
> > The patches are still under review, so I'm not 100% sure yet they will go
> > into 3.5.92, but since it's getting late I'm asking for approval before
> > they are fully reviewed. If this break is approved, I'll let you know when
> > these patches get committed.
> >
> > Thanks,
> >
> > christophe
>
> Given that it can be a potentially visible bug and it's only an easy
> string I would give my 1/2 i18n approval.
>
> Go try to find the other approvals!
>
> Cheers,

Approval 2/2, sounds pretty serious.

Regards
Gabor Kelemen