Re: String additions to 'brasero.HEAD'

[Philippe Rouquier <bonfire-app wanadoo fr>]

Le samedi 21 février 2009 à 12:06 +0000, Philip Withnall a écrit :
> On Sat, 2009-02-21 at 09:58 +0100, Claude Paroz wrote:
> > Le samedi 21 février 2009 à 08:19 +0000, GNOME Status Pages a écrit :
> > > This is an automatic notification from status generation scripts on:
> > > http://l10n.gnome.org.
> > > 
> > > There have been following string additions to module 'brasero.HEAD':
> > > 
> > > + "The size of the project is too large for the disc and you must remove files from the project otherwise.\nYou may want to use this option if you are using 90 or 100 min CD-R(W) which cannot be properly recognised and therefore need overburn option.\nNOTE: This option might cause failure."
> > > 
> > > Note that this doesn't directly indicate a string freeze break, but it
> > > might be worth investigating.
> > 
> > Hi Philippe,
> > 
> > Please revert this change:
> > http://svn.gnome.org/viewvc/brasero/trunk/src/brasero-burn-options.c?r1=1977&r2=1976&pathrev=1977
>
> Hi Claude,
>
> Philippe was merging two strings into one:
> http://bugzilla.gnome.org/show_bug.cgi?id=572622
>
> Does this really count as a string break? The translation stats for
> en_GB (at least) haven't changed since he committed the changes.
>
> Regards,
> Philip
>
> > This might go well for a change after you'll have branched. Moreover I'd
> > rather split the strings in brasero-data-disc.c rather than merge those
> > in brasero-burn-options.c. Smaller strings (when sensible) are better
> > for translation. 
> > 
> > Regards,
> > 
> > Claude
> > 
> > P.S. May I suggest you use a correct address in ChangeLogs :-)
> > 
> > 

Hi,

This has been fixed. It turns out I thought I had merged two strings but I actually had not. The string I changed differed from the other by one or two characters without my noticing it. I fixed it in trunk so now the string addition is gone.
For the record, I learnt from Claude that merging was not considered as a string freeze break.
So now all is fine.


And yes, Claude, I should nd will really fix this address issue. =) Thanks for your help.


Philippe