Re: String additions to 'hamster-applet.master'

[Toms <toms baugis gmail com>]

Sorry all, and I was in middle of writing a mail too :)
Now running ubuntu unstable, I found two bugs that hinder the overview
window from displaying in gnome 2.27.
The first one was with the duplicate IDs in the ui file. I hope that
you are referencing to the last line in the patch, Claude - fix for
the string change is in the attached em-dash.patch

The other one is an accidental typo for the single day view date
format. The fix is trivial, and for translators it means one added
string, which is the date format for single day. Changes are in the
attached context.patch file

Could I get approval to push these changes?

Regards,
Toms


On Mon, Aug 31, 2009 at 12:32 PM, Claude Paroz<claude 2xlibre net> wrote:
> Le lundi 31 août 2009 à 11:22 +0000, GNOME Status Pages a écrit :
>> This is an automatic notification from status generation scripts on:
>> http://l10n.gnome.org.
>>
>> There have been following string additions to module 'hamster-applet.master':
>>
>> + "Save report &#x2013; Time Tracker"
>>
>> Note that this doesn't directly indicate a string freeze break, but it
>> might be worth investigating.
>
> Hi Toms,
> Seems you inadvertantly changed a string in your last hamster-applet
> commit.
> http://git.gnome.org/cgit/hamster-applet/commit/?id=e9b7738328637ccc5aa49f63296c77c04927b7db
>
> Please revert.
>
> Claude
>
>

diff --git a/data/stats.ui b/data/stats.ui
index bfcf620..5bc8587 100644
--- a/data/stats.ui
+++ b/data/stats.ui
@@ -673,7 +673,7 @@
   </object>
   <object class="GtkFileChooserDialog" id="save_report_dialog">
     <property name="border_width">5</property>
-    <property name="title" translatable="yes">Save report &#x2013; Time Tracker</property>
+    <property name="title" translatable="yes">Save report – Time Tracker</property>
     <property name="modal">True</property>
     <property name="window_position">center</property>
     <property name="type_hint">normal</property>

diff --git a/hamster/stats.py b/hamster/stats.py
index eb07c5f..caf56cd 100644
--- a/hamster/stats.py
+++ b/hamster/stats.py
@@ -916,8 +916,8 @@ than 15 minutes you seem to be a busy bee." % ("<b>%d</b>" % short_percent))
             # date format for overview label when only single day is visible
             # Using python datetime formatting syntax. See:
             # http://docs.python.org/library/time.html#time.strftime
-            start_date_str = self.view_date.strftime("single day overview",
-                                                     "%B %d, %Y")
+            start_date_str = self.view_date.strftime(C_("single day overview",
+                                                        "%B %d, %Y"))
             # Overview label if looking on single day
             overview_label = _(u"Overview for %(date)s") % \
                                                       ({"date": start_date_str})