Re: pre-receive hook translation problem

[Simos Xenitellis <simos lists googlemail com>]

On Wed, Apr 29, 2009 at 3:00 PM, Adam Schreiber <sadam clemson edu> wrote:
> When creating a new remote branch for seahorse, I ran into the
> following problem:
>
> ------------------------------------------------------------------------------------------------------------------------------------
>
> $ git push origin gtk-doc
> Total 0 (delta 0), reused 0 (delta 0)
> ---
> The following translation (.po) file appears to be invalid. (When
> updating branch 'gtk-doc'.)
>
> po/bn.po
>
> The results of the validation follow. Please correct the errors on the
> line numbers mentioned and try to push again.
>
> <stdin>:772: number of format specifications in 'msgid' and
> 'msgstr[1]' does not match
> <stdin>:1459: number of format specifications in 'msgid' and
> 'msgstr[1]' does not match
> msgfmt: found 2 fatal errors
>
> To check this locally before attempting to push again, you can use the
> following command:
>
> msgfmt -c bn.po
>
> After making fixes, modify your commit to include them, by doing:
>
> git add bn.po
> git commit --amend
>
> If you have any further problems or questions, please contact the
> GNOME Translation Project mailing list <gnome-i18n gnome org>. Thank
> you.
> ---
> error: hooks/pre-receive exited with error code 1
> To ssh://sadam git gnome org/git/seahorse
>  ! [remote rejected] gtk-doc -> gtk-doc (pre-receive hook declined)
> error: failed to push some refs to 'ssh://sadam git gnome org/git/seahorse'
>
> ------------------------------------------------------------------------------------------------------------------------------------
>
> I checked po/bn.po and neither line contains format specifications.
> Is this an error in the translation, or should I take this up with the
> sysadmin team/whomever is maintaining that commit hook?

The message is

#. TODO: We can use the GPGME progress to make this more accurate
#: ../libseahorse/seahorse-pgp-source.c:723
#, c-format
msgid "Loaded %d key"
msgid_plural "Loaded %d keys"
msgstr[0] "%d-টি কি লোড করা হয়েছে"
msgstr[1] ""

The problem is that msgstr[1] has been left untranslated (plural
form), which causes the issue.
Apparently, the git hook for translations is activated when branches
are created.
Since the specific translation is about 2 years old, it appears it
managed to make it through the commit checks
that were introduced later.

I am not sure if there is a policy for this issues; I think the
typical thing to do is to mark those messages as fuzzy.
That is, change the above fragment to

#. TODO: We can use the GPGME progress to make this more accurate
#: ../libseahorse/seahorse-pgp-source.c:723
#, fuzzy, c-format
msgid "Loaded %d key"
msgid_plural "Loaded %d keys"
msgstr[0] "%d-টি কি লোড করা হয়েছে"
msgstr[1] ""

Simos