Re: libgnomeui broke the string freeze



On 9/3/06, Christian Rose <menthos gnome org> wrote:
On 9/2/06, Wouter Bolsterlee <uws+gnome xs4all nl> wrote:
> The libgnomeui commit [1] by Kristian Rietveld introduced a new string [2],
> which is unacceptable in string freeze, 4 days before a release. There has
> not been any notification sent out to to gnome-i18n either...
>
> Please revert the patch or make sure you reuse an already existing string.
>
>   thanks, Wouter
>
> [1] http://cvs.gnome.org/viewcvs/libgnomeui/file-chooser/gtkfilesystemgnomevfs.c?r1=1.80&r2=1.81
> [2] "Error getting information for '%s'"

Indeed, this is not acceptable. Kris, could you please revert this
string addition?

Reverting the patch would give you a gnome release with a very broken
filechooser. Do you really want that ?

And removing the _() just for formal string freeze reasons would be a
bit silly, since the end effect would be just the same, an
untranslated error message...

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]