Re: evince string freeze breackage



El miÃ, 17-08-2005 a las 14:34 -0400, Matthias Clasen escribiÃ:
> On Wed, 2005-08-17 at 19:40 +0200, Carlos Garcia Campos wrote:
> > El miÃ, 17-08-2005 a las 19:23 +0200, Danilo Åegan escribiÃ:
> > > Hi Carlos,
> > > 
> > > Today at 18:45, Carlos Garcia Campos wrote:
> > > 
> > > > My apologies, I broke the string freeze in this evince commit:
> > > >
> > > > http://cvs.gnome.org/viewcvs/evince/ps/ps-document.c?r1=1.55&r2=1.56
> > > 
> > > Nice that you reported it yourself.  Can you now tell us why is
> > > introducing these three strings
> > > 
> > > "Error while decompressing file\n"
> > > "Cannot open file.\n"
> > > "Failed to load document"
> > 
> > if we can't convert a filename to a utf-8 string, we prefer not to show
> > that filename.
> 
> Glib has g_filename_display_name() for the purpose of converting
> filenames into something that can be displayed to the user. It tries
> to handle conversion failures gracefully.

I've just fixed it by using g_filename_display_name, thank you. 

Sorry for the problems caused, I'll be more careful in the future

> Matthias
> 

Greetings, 
-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Carlos Garcia Campos a.k.a. KaL
   elkalmail yahoo es
   carlosgc gnome org
   http://carlosgc.linups.org
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=             
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]