Re: evince string freeze breackage



El miÃ, 17-08-2005 a las 19:23 +0200, Danilo Åegan escribiÃ:
> Hi Carlos,
> 
> Today at 18:45, Carlos Garcia Campos wrote:
> 
> > My apologies, I broke the string freeze in this evince commit:
> >
> > http://cvs.gnome.org/viewcvs/evince/ps/ps-document.c?r1=1.55&r2=1.56
> 
> Nice that you reported it yourself.  Can you now tell us why is
> introducing these three strings
> 
> "Error while decompressing file\n"
> "Cannot open file.\n"
> "Failed to load document"

if we can't convert a filename to a utf-8 string, we prefer not to show
that filename.

> actually necessary and important at this stage of the game?

maybe not, but I guess evince maintainers should answer it. 

> They are used only if g_locale_to_utf8 fails to convert filename to
> UTF-8 for display purposes, right?  (you can reuse the same string
> with something like g_strdup_printf(_("Cannot open file: %s\n"), "?")
> until string freeze ends.)

yes

> Can you please revert these string additions or please provide more
> evidence to why is this really beneficial.  Thanks.
> 
> > I wanted to commit ASAP because of the evince release and I forgot that
> > it changed some strings. sorry. 
> 
> Regarding recent "when freeze actually begins"[1] thread, are you
> saying that this is about a release done for the Beta2?  Beta2 was
> already announced on August 11th, and the patch was committed only on
> August 16th.

oh no, I meant new evince release to fix building problems:

http://bugzilla.gnome.org/show_bug.cgi?id=309915#c10

> [1]http://mail.gnome.org/archives/gnome-i18n/2005-August/msg00160.html
> 
> Cheers,
> Danilo
> 
-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Carlos Garcia Campos a.k.a. KaL
   elkalmail yahoo es
   carlosgc gnome org
   http://carlosgc.linups.org
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=             
PGP key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x523E6462

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]