Re: request for freeze breakage - gok

[Christian Rose <menthos gnome org>]

ons 2004-09-08 klockan 13.51 skrev Bill Haneman:
> On Wed, 2004-09-08 at 12:34, Murray Cumming wrote:
> > > module: gok
> > > maintainers: David Bolter, Bill Haneman
> > > bug: http://bugzilla.gnome.org/show_bug.cgi?id=152086
> > > patch: http://bugzilla.gnome.org/attachment.cgi?id=31390&action=view
> > >
> > > We've discovered that our gok-with-references.schemas.m4 file is busted.
> > >
> > > This doesn't matter for a casual install from tarball or cvs, but
> > > matters if a developer or translator decides to update the schemas.in
> > > file (as per the somewhat buried directions) however it means that 17
> > > strings are erroneously going unmarked; fixing the m4 file will cause
> > > the strings to become marked.
> > 
> > What will the user experience in this case? Or, what does the bug look
> > like in practice?
> 
> 1) User who does 'make install': no build impact, but 17 strings go
> untranslated for end users.
> 
> 2) User/maintainer who manually runs m4 (as documented in
> gok-with-references.schemas.in): build breakage and/or runtime breakage
> after manually regenerating the .schemas.in file.: GOK won't run
> afterwards.
> 
> #2 is not a common case; by that logic, fixing the macro is both
> low-risk and low-urgency.  But since it's a build-ish scenario, we
> thought release-team should be informed of the issue.
> 
> Personally I think there's no harm in fixing the macro, since in
> scenario #1 the change to the macro will have no effect, since the
> patched file isn't touched at all, and in scenario #2 we go from 'very
> broken' to 'missing a few translations'.

How visible are these untranslated strings?

If they're not very visible, I think I'd lend against punting it for now
(2.8.0) and revisiting the issue for GNOME 2.8.1, since it's quite a lot
of messages for being this late in the game.


Christian