Re: request for freeze breakage - gok

["Murray Cumming" <murrayc murrayc com>]

>> What will the user experience in this case? Or, what does the bug look
>> like in practice?
>
> 1) User who does 'make install': no build impact, but 17 strings go
> untranslated for end users.
>
> 2) User/maintainer who manually runs m4 (as documented in
> gok-with-references.schemas.in): build breakage and/or runtime breakage
> after manually regenerating the .schemas.in file.: GOK won't run
> afterwards.
>
> #2 is not a common case; by that logic, fixing the macro is both
> low-risk and low-urgency.  But since it's a build-ish scenario, we
> thought release-team should be informed of the issue.
>
> Personally I think there's no harm in fixing the macro, since in
> scenario #1 the change to the macro will have no effect, since the
> patched file isn't touched at all, and in scenario #2 we go from 'very
> broken' to 'missing a few translations'.

OK, I don't really care about risks to #2 [1], so if the change really
does not affect #1, then here's 1 approval of a necessary 2.

[1] It sounds like something that distros might want to do, but they get
to fix small things later anyway.

Thanks.


Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com